Re: [PATCH v2] completion: add new git_complete helper

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Apr 16, 2012, 20:59 UTC
Message-ID: <20120416205952.GJ12613@burratino>
In-Reply-To: <CAMP44s23_Qx3R9TX4frM-JYNv7XT3eVbcZ_D45nEdh0rq-O8kA@mail.gmail.com>

(cc-ing the bash-completion-devel list) Felipe Contreras wrote:

> On Mon, Apr 16, 2012 at 11:46 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Felipe Contreras wrote:

Show 8 quoted lines

>>> Now, even if you use the bash completion library, it still does export
>>> functions without a prefix
>>
>> Are you sure?  "complete" is a bash builtin and has nothing to do with
>> the bash completion library except that the latter uses it.
>
> I already provided examples:
> have(), quote(), dequote(), quote_readline()

Ah, that's what you mean. Thanks for the pointers, and sorry to have misunderstood.

There's a little oddity here. "have" is clearly an unwanted backward compatibility feature:

	# @deprecated should no longer be used; generally not needed with dynamically
	#             loaded completions, and _have is suitable for runtime use.
	have()
	[...]
	unset -f have
	unset have

But "quote", "dequote", and "quote_readline" do not get the same treatment. Perhaps they are for backward compatibility, too, but are so widely used that there is no hope of ever getting rid of them.

Hopefully this information helps clarify to what extent the leading underscores in functions exposed by completion scripts are meant or are not meant as a convention.

Jonathan

_______________________________________________ Bash-completion-devel mailing list Bash-completion-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/bash-completion-devel