From: Derrick Stolee <stolee@gmail.com>
Date: Wed, 21 Nov 2018 11:33:56 GMT
Subject: Re: [PATCH 2/2] commit-graph: don't call write_graph_chunk_large_edges() unnecessarily
Message-ID: <6d9ce874-0d96-1312-5b9f-71a8db20ce9b@gmail.com>
In-Reply-To: <20181121012600.26951-1-szeder.dev@gmail.com>

On 11/20/2018 8:26 PM, SZEDER Gábor wrote:
>   	write_graph_chunk_data(f, GRAPH_OID_LEN, commits.list, commits.nr);
> -	write_graph_chunk_large_edges(f, commits.list, commits.nr);
> +	if (num_large_edges)
> +		write_graph_chunk_large_edges(f, commits.list, commits.nr);

This is clearly correct, and the tests in t5318-commit-graph.sh would 
catch a dropped (or additional) large/extra edge chunk.

Thanks,

-Stolee