Re: [PATCH v2 3/8] refs: factor update_ref steps into helpers

From: Brad King <brad.king@kitware.com>
Date: Sep 2, 2013, 17:19 UTC
Message-ID: <5224C89D.3050002@kitware.com>
In-Reply-To: <xmqqvc2lul9g.fsf@gitster.dls.corp.google.com>

On 09/01/2013 02:08 AM, Junio C Hamano wrote:

Show 7 quoted lines

> Brad King <brad.king@kitware.com> writes:
>>  	static struct ref_lock *lock;
> 
> Not the fault of this patch, as the original update_ref() had it
> this way, but it is not necessary to keep the value of this variable
> across invocations.  Let's drop "static" from here, and also the
> corresponding variable in the new update_ref().

Fixed in next revision.

Thanks, -Brad

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.