Re: [PATCH/RFC 2/7] refs: report ref type from lock_any_ref_for_update
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 29, 2013, 17:22 UTC
- Message-ID
- <xmqqtxi85s50.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <80d72f6f4bf04a8fef8ebfcc02a463e769cea3d4.1377784597.git.brad.king@kitware.com>
Brad King <brad.king@kitware.com> writes:
Show 14 quoted lines
> Expose lock_ref_sha1_basic's type_p argument to callers of
> lock_any_ref_for_update. Update all call sites to ignore it; we will
> use it later.
> ...
> diff --git a/branch.c b/branch.c
> index c5c6984..c244483 100644
> --- a/branch.c
> +++ b/branch.c
> @@ -291,7 +291,7 @@ void create_branch(const char *head,
> hashcpy(sha1, commit->object.sha1);
>
> if (!dont_change_ref) {
> - lock = lock_any_ref_for_update(ref.buf, NULL, 0);
> + lock = lock_any_ref_for_update(ref.buf, NULL, 0, 0);If you are passing an NULL as a new parameter, please spell it "NULL", not "0".