From: Brad King <brad.king@kitware.com>
Date: Mon, 02 Sep 2013 17:19:25 GMT
Subject: Re: [PATCH v2 3/8] refs: factor update_ref steps into helpers
Message-ID: <5224C89D.3050002@kitware.com>
In-Reply-To: <xmqqvc2lul9g.fsf@gitster.dls.corp.google.com>

On 09/01/2013 02:08 AM, Junio C Hamano wrote:
> Brad King <brad.king@kitware.com> writes:
>>  	static struct ref_lock *lock;
> 
> Not the fault of this patch, as the original update_ref() had it
> this way, but it is not necessary to keep the value of this variable
> across invocations.  Let's drop "static" from here, and also the
> corresponding variable in the new update_ref().

Fixed in next revision.

Thanks,
-Brad