Re: [PATCH v3 8/8] update-ref: add test cases covering --stdin signature
- From
Brad King <brad.king@kitware.com>
- Date
- Sep 3, 2013, 12:15 UTC
- Message-ID
- <5225D2F9.8000908@kitware.com>
- In-Reply-To
- <CAPig+cRZFAaa1WVUa9V3jC9Oiy+ucSvyRAc0jdgwQASmhZm6eA@mail.gmail.com>
On 09/03/2013 04:16 AM, Eric Sunshine wrote:
> When you decomposed the monolithic test from v1 into individual tests,
> you dropped a couple cases ("fatal: unknown option'" and "fatal:
> unterminated single-quote"). Was this intentional?Yes. The v3 patch 7 changed the set of error messages to be covered.
> The leading '-' on '-EOF' allows you to indent the content of the > heredoc and the terminating EOF, which makes the test read nicely:
Very nice. Fixed for next iteration.
Thanks, -Brad