Re: [PATCH 1/3] Fixing path quoting in git-rebase

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Oct 15, 2007, 13:39 UTC
Message-ID: <47136D92.8060104@viscovery.net>
In-Reply-To: <11924540292687-git-send-email-maillist@steelskies.com>

Jonathan del Strother schrieb:

> -	eval GITHEAD_$hd='"$(cat $dotest/onto_name)"'
> +	eval GITHEAD_$hd='"$(cat \"$dotest/onto_name\")"'

I believe this is not correct. It should be this way:

	eval GITHEAD_$hd='$(cat "$dotest/onto_name")'

You can test it with a conflicting git-rebase -m. It only affects what the conflict markers look like. The test suite does not test it.

The rest looks good.

-- Hannes

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.