Re: [PATCH] Fixing path quoting issues

From: Jonathan del Strother <maillist@steelskies.com>
Date: Oct 13, 2007, 18:12 UTC
Message-ID: <92879AC5-2927-439B-8EB0-AC20AAEE412E@steelskies.com>
In-Reply-To: <470DC05A.8020209@viscovery.net>

On 11 Oct 2007, at 07:19, Johannes Sixt wrote:

Show 13 quoted lines

>> -	 git-commit -F msg -m amending ."
>> +	git-commit -F msg -m amending ."
>
> You fix whitespace...
>
>>  test_expect_success \
>> -	"using message from other commit" \
>> -	"git-commit -C HEAD^ ."
>> +	 "using message from other commit" \
>> +	 "git-commit -C HEAD^ ."
>
> ... and you break it. More of these follow. Don't do that, it makes  
> patch review unnecessarily hard.

I'm just preparing to release this patch... was that "don't break whitespace", or "don't try to fix whitespace in a patch that's has nothing to do with whitespacing-fixing" ?

And while I'm here - tabs are preferred, are they? There seem to be a mixture of tabs & 4 space indentation.