Re: [PATCH] Fixing path quoting issues
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Oct 11, 2007, 07:10 UTC
- Message-ID
- <470DCC76.7070809@viscovery.net>
- In-Reply-To
- <854pgytafi.fsf@lola.goethe.zz>
David Kastrup schrieb:
Show 7 quoted lines
> Johannes Sixt <j.sixt@viscovery.net> writes: >> IMHO, it's not too much of a burden for developers to require "sane" >> build directory paths. > > For a normal user, the only writable directories might be of the > "C:\Programs and Data\User settings\Karl" > variety.
I whole-heartedly agree about the part of the patch that fixes git-rebase.sh. This should be a separate patch.
But the reset of the patch is about running the test suite, and it is much more difficult to fix because of the 'eval' that is going on. And, yes, I do think that we can expect that contributors, including this handful of people on Windows, have a "sane" build directory.
-- Hannes