Re: [PATCH 2/3] Quoting paths in tests
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Oct 15, 2007, 13:47 UTC
- Message-ID
- <47136F71.1050107@viscovery.net>
- In-Reply-To
- <11924540291536-git-send-email-maillist@steelskies.com>
Jonathan del Strother schrieb:
Show 6 quoted lines
> - svn import -m 'import for git-svn' . $svnrepo >/dev/null && > + svn import -m 'import for git-svn' . '$svnrepo' >/dev/null && > cd .. && > rm -rf import && > - git-svn init $svnrepo" > + git-svn init '$svnrepo'"
I don't see the point in changing an incorrect quoting to a different incorrect quoting that you fix up in a follow-up patch. It's *two* large patches to review instead of just one. I'm stopping the review here.
-- Hannes