From: Johannes Sixt <j.sixt@viscovery.net>
Date: Mon, 15 Oct 2007 13:39:30 GMT
Subject: Re: [PATCH 1/3] Fixing path quoting in git-rebase
Message-ID: <47136D92.8060104@viscovery.net>
In-Reply-To: <11924540292687-git-send-email-maillist@steelskies.com>

Jonathan del Strother schrieb:
> -	eval GITHEAD_$hd='"$(cat $dotest/onto_name)"'
> +	eval GITHEAD_$hd='"$(cat \"$dotest/onto_name\")"'

I believe this is not correct. It should be this way:

	eval GITHEAD_$hd='$(cat "$dotest/onto_name")'

You can test it with a conflicting git-rebase -m. It only affects what the 
conflict markers look like. The test suite does not test it.

The rest looks good.

-- Hannes