Re: [PATCH] Fixing path quoting issues

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 11, 2007, 21:31 UTC
Message-ID: <Pine.LNX.4.64.0710112227000.4174@racer.site>
In-Reply-To: <63D5CE5B-51DD-4017-B2E2-2ADC5DCBE849@steelskies.com>

Hi,

On Thu, 11 Oct 2007, Jonathan del Strother wrote:

Show 12 quoted lines

> On 11 Oct 2007, at 21:53, David Kastrup wrote:
> 
> > Johannes Sixt <j.sixt@viscovery.net> writes:
> > 
> > > Jonathan del Strother schrieb:
> > > > How are you going to test that git works on paths with spaces if the
> > > > test suite doesn't run there?
> > > 
> > > By writing a specific test?
> > 
> > This is going to be much less thorough.  And it does no harm if the 
> > test scripts demonstrate defensive programming.

We do not have _extensive_ tests. We want to do some coding in addition to waiting for our machines to finish the test. D'oh.

> I would also point out that most tests have already been written to 
> handle this case - ones that don't quote their paths are in the 
> minority.

That might very well be the case, and your goal is laudable. However, I have to agree that most devs (indeed, since you are the first to try to fix it, _all_ except for you) do not care that deeply about spaces in the path, and having a _single_ test for this would be the logical solution.

I mean, we do not force our main developers to run the most obscure setups all the time just to make sure that it runs fine. Otherwise none of us could run Linux, but a couple would be coerced into running Windows, for example.

Ciao, Dscho