Re: [PATCH] Fixing path quoting issues
- From
Wincent Colaiuta <win@wincent.com>
- Date
- Oct 12, 2007, 12:20 UTC
- Message-ID
- <A7970E82-92E0-4267-AF79-D4ABDB21F0D0@wincent.com>
- In-Reply-To
- <Pine.LNX.4.64.0710121235230.25221@racer.site>
El 12/10/2007, a las 13:37, Johannes Schindelin escribió:
Show 22 quoted lines
> On Fri, 12 Oct 2007, Wincent Colaiuta wrote: > >> El 11/10/2007, a las 22:53, David Kastrup escribió: >> >>> Johannes Sixt <j.sixt@viscovery.net> writes: >>> >>>> Jonathan del Strother schrieb: >>>>> How are you going to test that git works on paths with spaces >>>>> if the >>>>> test suite doesn't run there? >>>> >>>> By writing a specific test? >>> >>> This is going to be much less thorough. And it does no harm if the >>> test scripts demonstrate defensive programming. >> >> +1: especially in this case, where it really is "defensive" and not >> "paranoiac". > > I am all for it, _iff_ the guilty parties (and by that, I mean > _you_) do > it and keep maintaining it. See? Discussion closed already.
How am *I* the guilty party? I'm merely endorsing David's comment that a modicum of defensive programming isn't a bad thing; an eminently reasonable position which is somewhat difficult to argue against.
Cheers, Wincent