Re: [PATCH 7/7] t7814: show lack of alternate ODB-adding

From: Jonathan Tan <jonathantanmy@google.com>
Date: Aug 13, 2021, 16:50 UTC
Message-ID: <20210813165045.3220845-1-jonathantanmy@google.com>
In-Reply-To: <CAHd-oW7NKNeujverFiRUR2p1nfOpjrv1xDrsvTVa1Yw5jC1D0w@mail.gmail.com>

Show 8 quoted lines

> Hmm, there is at least one call chain in grep which might end up
> calling add_to_alternates_memory() directly (although it only seems to
> happen on a very specific case):
> 
>         grep_submodule > repo_read_gitmodules >
>         config_from_gitmodules > add_to_alternates_memory
> 
> We can check that with the following:

[snip reproduction recipe]

Thanks - it looks like my patch set is incomplete then. I'll make config_from_gitmodules() use my new function and if the existing grep test cases don't cover your reproduction recipe, I'll add yours in.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.