Re: [PATCH v3 0/8] In grep, no adding submodule ODB as alternates

From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date: Sep 8, 2021, 15:31 UTC
Message-ID: <CAHd-oW5VBzZ+mgzsQ65eTD70q53+-Yri=pFW7ffvt95AmC7rVQ@mail.gmail.com>
In-Reply-To: <xmqq8s079al1.fsf@gitster.g>

On Tue, Sep 7, 2021 at 9:26 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 21 quoted lines

>
> Jonathan Tan <jonathantanmy@google.com> writes:
>
> > Thanks for reviewing, everyone. Here are the requested changes.
> >
> > Jonathan Tan (8):
> >   submodule: lazily add submodule ODBs as alternates
> >   grep: use submodule-ODB-as-alternate lazy-addition
> >   grep: typesafe versions of grep_source_init
> >   grep: read submodule entry with explicit repo
> >   grep: allocate subrepos on heap
> >   grep: add repository to OID grep sources
> >   submodule-config: pass repo upon blob config read
> >   t7814: show lack of alternate ODB-adding
>
> I didn't see anybody comment on this round (and do not think I saw
> anything glaringly wrong).
>
> Is everybody happy with this version?  I am about to mark it for
> 'next' in the next issue of "What's cooking" report, so please
> holler if I should wait.

I think it's ready for 'next'. Jonathan addressed all my comments from previous rounds; I also just read the patches again and all looks good to me. Feel free to include my:

Reviewed-by: Matheus Tavares <matheus.bernardino@usp.br>