Re: [PATCH 4/7] grep: read submodule entry with explicit repo
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Aug 13, 2021, 16:39 UTC
- Message-ID
- <20210813163901.3214789-1-jonathantanmy@google.com>
- In-Reply-To
- <YRREyrAXBmxVoxRr@google.com>
Show 7 quoted lines
> > - object = parse_object_or_die(oid, NULL); > > + object_type = oid_object_info(&subrepo, oid, NULL); > > One thing I wonder is whether we are missing out on some error > conditions we used to get with parse_object_or_die() by using > oid_object_info() instead. Do we need to be more defensive in > investigating 'oid' before calling that helper, now?
For the purposes of grep, I don't think that this matters - we just want to find the ultimate tree that this object represents.