From: Jonathan Tan <jonathantanmy@google.com>
Date: Fri, 13 Aug 2021 16:50:45 GMT
Subject: Re: [PATCH 7/7] t7814: show lack of alternate ODB-adding
Message-ID: <20210813165045.3220845-1-jonathantanmy@google.com>
In-Reply-To: <CAHd-oW7NKNeujverFiRUR2p1nfOpjrv1xDrsvTVa1Yw5jC1D0w@mail.gmail.com>

> Hmm, there is at least one call chain in grep which might end up
> calling add_to_alternates_memory() directly (although it only seems to
> happen on a very specific case):
> 
>         grep_submodule > repo_read_gitmodules >
>         config_from_gitmodules > add_to_alternates_memory
> 
> We can check that with the following:

[snip reproduction recipe]

Thanks - it looks like my patch set is incomplete then. I'll make
config_from_gitmodules() use my new function and if the existing grep
test cases don't cover your reproduction recipe, I'll add yours in.