Re: [PATCH 3/7] grep: typesafe versions of grep_source_init

From: Jonathan Tan <jonathantanmy@google.com>
Date: Aug 13, 2021, 16:32 UTC
Message-ID: <20210813163241.3213428-1-jonathantanmy@google.com>
In-Reply-To: <YRRYOmwW9yKhvldn@satellite>

Show 6 quoted lines

> Just a quick note: grep_source_init_buf() is only called from
> grep.c:1833, before its definition at grep.c:1869, so it could be marked
> as static (as things stand). Do you anticipate any future callers from
> outside of grep.c? (after removing the declaration from grep.h, you
> would need to add a forward declaration or, better, move the definition
> to before the call (or the call (and grep_buffer()) after the definition)).

No, I do not - thanks for the note, and I'll make it static in the next reroll.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.