Re: [PATCH 1/7] submodule: lazily add submodule ODBs as alternates

From: Jonathan Tan <jonathantanmy@google.com>
Date: Aug 13, 2021, 16:53 UTC
Message-ID: <20210813165343.3225573-1-jonathantanmy@google.com>
In-Reply-To: <xmqqtujxc8a3.fsf@gitster.g>

Show 5 quoted lines

> > +static struct string_list added_submodule_odb_paths = STRING_LIST_INIT_NODUP;
> > +
> 
> I see 2/7 allows callers to add paths for submodule odb to this
> list.

Yes, and as you said below, add_submodule_odb() has been modified to add to this list too.

Show 6 quoted lines

> The "pretend as if objects in submodule odb are locally available",
> even though it may have been useful, was an ugly hack invented
> before we started adding the "access more than one repository at the
> time with the 'repo' arg" extended API.  It is pleasing to see this
> step shows an approach to incrementally migrate the users of the
> hack.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.