Re: [PATCH 3/7] grep: typesafe versions of grep_source_init

From: Emily Shaffer <emilyshaffer@google.com>
Date: Aug 11, 2021, 21:42 UTC
Message-ID: <YRREPNA8GPyKdWBr@google.com>
In-Reply-To: <e5e6a0dc1ef59b2ab419816e463814d93115e7f6.1628618950.git.jonathantanmy@google.com>

On Tue, Aug 10, 2021 at 11:28:41AM -0700, Jonathan Tan wrote:

Show 9 quoted lines

> 
> grep_source_init() can create "struct grep_source" objects and,
> depending on the value of the type passed, some void-pointer parameters have
> different meanings. Because one of these types (GREP_SOURCE_OID) will
> require an additional parameter in a subsequent patch, take the
> opportunity to increase clarity and type safety by replacing this
> function with individual functions for each type.
> 
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>

Like Junio said, it is very neat.

Reviewed-by: Emily Shaffer <emilyshaffer@google.com>

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.