Re: [PATCH v6 1/3] ref-filter: add worktreepath atom

From: Jeff King <peff@peff.net>
Date: Jan 31, 2019, 23:20 UTC
Message-ID: <20190131232057.GA3843@sigill.intra.peff.net>
In-Reply-To: <xmqqef8s1p3d.fsf@gitster-ct.c.googlers.com>

On Thu, Jan 31, 2019 at 01:42:14PM -0800, Junio C Hamano wrote:

Show 7 quoted lines

> > So I'd much rather see us parse the format into a real tree of nodes,
> > and figure out (once) which properties of each object are required to
> > fulfill that. Then for each object, we grab those properties, and then
> > walk the tree to generate the output string.
> 
> That sounds like a sensible longer-term strategy.  Let's however
> leave it outside the scope of this change.

Yeah, sorry if I got us too far afield. It's definitely out of scope for this series. The takeaway I was trying to get at is that storing the worktree map as a static global is actually pretty reasonable given the current design.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.