Re: [PATCH v7 1/3] ref-filter: add worktreepath atom
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 4, 2019, 18:14 UTC
- Message-ID
- <xmqqsgx3v2sy.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CAC05386a+FZP8hGawYsfZrmA--JuZBqi_aop7202JQnJEfKyJg@mail.gmail.com>
Nickolai Belakovski <nbelakovski@gmail.com> writes:
> There's been a little back and forth on it, but my understanding is > that using the colon separator bypasses the caching mechanism in the > atoms, so every instance of "worktree:path" in a format string would > require a lookup.
Would that be a problem, though? You now have a singleton hashmap that is a file-scope global not tied to any particular atom, so...?