Re: [PATCH v7 1/3] ref-filter: add worktreepath atom

From: Nickolai Belakovski <nbelakovski@gmail.com>
Date: Feb 18, 2019, 10:09 UTC
Message-ID: <CAC05384mbqpq5QZJiXvVoKZyCx21ATM5TcKscnuKdbR0wi5o=w@mail.gmail.com>
In-Reply-To: <xmqqsgx3v2sy.fsf@gitster-ct.c.googlers.com>

Well, it sounded like we didn't like the ":" extender from another conversation on this thread. Do you think this patch should move back in that direction?

On Tue, Feb 5, 2019 at 3:14 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

>
> Nickolai Belakovski <nbelakovski@gmail.com> writes:
>
> > There's been a little back and forth on it, but my understanding is
> > that using the colon separator bypasses the caching mechanism in the
> > atoms, so every instance of "worktree:path" in a format string would
> > require a lookup.
>
> Would that be a problem, though?  You now have a singleton hashmap
> that is a file-scope global not tied to any particular atom, so...?