Re: [PATCH v10 0/3]

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Apr 29, 2019, 14:12 UTC
Message-ID: <20190429141224.GA9286@szeder.dev>
In-Reply-To: <20190429051944.77164-1-nbelakovski@gmail.com>

On Sun, Apr 28, 2019 at 10:19:41PM -0700, nbelakovski@gmail.com wrote:

Show 7 quoted lines

> From: Nickolai Belakovski <nbelakovski@gmail.com>
> 
> Added test_i18ncmp per instructions from Szeder
> 
> Is there some other part of the infrastructure that's testing for this? Because it did not fail in any of my Travis CI builds.
> 
> Travis CI results: https://travis-ci.org/nbelakovski/git/builds/525801210

Testing with GETTEXT_POISON was broken since 6cdccfce (i18n: make GETTEXT_POISON a runtime option, 2018-11-08), and didn't catch any of these issues. See:

  https://public-inbox.org/git/xmqqlg0bvppc.fsf_-_@gitster-ct.c.googlers.com/T/#u

The fix f88b9cb603 (gettext tests: export the restored GIT_TEST_GETTEXT_POISON, 2019-04-15) was merged to master just last week.