Re: [PATCH v8 0/3]

From: Nickolai Belakovski <nbelakovski@gmail.com>
Date: Mar 14, 2019, 06:10 UTC
Message-ID: <CAC05385woS0XUsDHRBHrZkjzFU9q9+JOJ3BvE8pRh48794-iBA@mail.gmail.com>
In-Reply-To: <20190221123646.GA12185@sigill.intra.peff.net>

Show 5 quoted lines

>
> Patch 1 looks good to me. Given that we're on v8 and most of the other
> comments are for patches 2 and 3, I think we might consider graduating
> it separately if the other two are not ready soon. It's independently
> useful, IMHO.

Patch 2 was my main motivation, so it would be nice to get it in together with 1 :) Patch 3, like I said in the thread on that one I don't have strong feeling about it. It was an attempt to provide a connection between the new cyan output and its intent, as opposed to having the user guess, but I think anyone who's using a worktree will figure it out sooner or later, and anyone not using a worktree will be unaffected.

I'm willing to keep going with comments on patch 2. I can't imagine it would take many more revisions as it's much more straightforward than patch 1, it's basically just modifying one line of branch.c. If we decide to drop patch 3 fine with me.

I'll send in v9 with the latest changes for both 2 and 3 sometime tomorrow unless I hear otherwise.

Thanks for the feedback.