From: Jeff King Date: Thu, 31 Jan 2019 23:20:58 GMT Subject: Re: [PATCH v6 1/3] ref-filter: add worktreepath atom Message-ID: <20190131232057.GA3843@sigill.intra.peff.net> In-Reply-To: On Thu, Jan 31, 2019 at 01:42:14PM -0800, Junio C Hamano wrote: > > So I'd much rather see us parse the format into a real tree of nodes, > > and figure out (once) which properties of each object are required to > > fulfill that. Then for each object, we grab those properties, and then > > walk the tree to generate the output string. > > That sounds like a sensible longer-term strategy. Let's however > leave it outside the scope of this change. Yeah, sorry if I got us too far afield. It's definitely out of scope for this series. The takeaway I was trying to get at is that storing the worktree map as a static global is actually pretty reasonable given the current design. -Peff