Re: [PATCH v3 07/10] connect: tell server that the client understands v1
On 10/10, Jonathan Tan wrote:
Show 17 quoted lines
> On Tue, 3 Oct 2017 13:15:04 -0700
> Brandon Williams <bmwill@google.com> wrote:
>
> > 2. ssh://, file://
> > Set 'GIT_PROTOCOL' environment variable with the desired protocol
> > version. With the file:// transport, 'GIT_PROTOCOL' can be set
> > explicitly in the locally running git-upload-pack or git-receive-pack
> > processes. With the ssh:// transport and OpenSSH compliant ssh
> > programs, 'GIT_PROTOCOL' can be sent across ssh by using '-o
> > SendEnv=GIT_PROTOCOL' and having the server whitelist this
> > environment variable.
>
> In your commit message, also mention what GIT_PROTOCOL contains
> (version=?). (From this commit message alone, I would have expected a
> lone integer, but that is not the case.)
>
> Same comment for the commit message of PATCH v3 08/10.
I'll update the commit msgs.
--
Brandon Williams