Re: [PATCH v2 0/5] Coping with unrecognized ssh wrapper scripts in GIT_SSH

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 24, 2017, 02:22 UTC
Message-ID: <xmqq1slt9tdt.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171023231625.6mhcyqti7vdg6yot@aiede.mtv.corp.google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 17 quoted lines

> Jonathan Tan wrote:
>>> On 10/23, Jonathan Nieder wrote:
>
>>>> If this looks good, I can reroll in a moment.
>>
>> Yes, this looks good.
>
> Thanks.  Here goes.
>
> The interdiff is upthread.  Thanks, all, for the quick review.
>
> Jonathan Nieder (5):
>   connect: split git:// setup into a separate function
>   connect: split ssh command line options into separate function
>   ssh: 'auto' variant to select between 'ssh' and 'simple'
>   ssh: 'simple' variant does not support -4/-6
>   ssh: 'simple' variant does not support --port

These looked mostly good. I left some nitpicks on individual patches.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.