Re: [PATCH v2 6/9] connect: teach client to recognize v1 server response
- From
- Brandon Williams <bmwill@google.com>
- Date
- Sep 27, 2017, 17:34 UTC
- Message-ID
- <20170927173409.GA161070@google.com>
- In-Reply-To
- <xmqqh8vp7xv4.fsf@gitster.mtv.corp.google.com>
On 09/27, Junio C Hamano wrote:
Show 21 quoted lines
> Brandon Williams <bmwill@google.com> writes:
>
> > +/* Returns 1 if packet_buffer is a protocol version pkt-line, 0 otherwise. */
> > +static int process_protocol_version(void)
> > +{
> > + switch (determine_protocol_version_client(packet_buffer)) {
> > + case protocol_v1:
> > + return 1;
> > + case protocol_v0:
> > + return 0;
> > + default:
> > + die("server is speaking an unknown protocol");
> > + }
> > +}
>
> checkpatch.pl yells at me:
>
> ERROR: switch and case should be at the same indent
>
> and we would probably want to teach "make style" the same, if we
> already don't.'make style' actually already understands this, I just forgot it run it on this change :)
-- Brandon Williams