Re: [PATCH v2 6/9] connect: teach client to recognize v1 server response
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 27, 2017, 01:07 UTC
- Message-ID
- <xmqqh8vp7xv4.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170926235627.79606-7-bmwill@google.com>
Brandon Williams <bmwill@google.com> writes:
Show 12 quoted lines
> +/* Returns 1 if packet_buffer is a protocol version pkt-line, 0 otherwise. */
> +static int process_protocol_version(void)
> +{
> + switch (determine_protocol_version_client(packet_buffer)) {
> + case protocol_v1:
> + return 1;
> + case protocol_v0:
> + return 0;
> + default:
> + die("server is speaking an unknown protocol");
> + }
> +}checkpatch.pl yells at me:
ERROR: switch and case should be at the same indent
and we would probably want to teach "make style" the same, if we already don't.