From: Brandon Williams <bmwill@google.com>
Date: Fri, 13 Oct 2017 22:56:03 GMT
Subject: Re: [PATCH v3 07/10] connect: tell server that the client understands v1
Message-ID: <20171013225603.GE101395@google.com>
In-Reply-To: <20171010113021.0a23506a5d1ebaf4e8ff1f9a@google.com>

On 10/10, Jonathan Tan wrote:
> On Tue,  3 Oct 2017 13:15:04 -0700
> Brandon Williams <bmwill@google.com> wrote:
> 
> > 2. ssh://, file://
> >    Set 'GIT_PROTOCOL' environment variable with the desired protocol
> >    version.  With the file:// transport, 'GIT_PROTOCOL' can be set
> >    explicitly in the locally running git-upload-pack or git-receive-pack
> >    processes.  With the ssh:// transport and OpenSSH compliant ssh
> >    programs, 'GIT_PROTOCOL' can be sent across ssh by using '-o
> >    SendEnv=GIT_PROTOCOL' and having the server whitelist this
> >    environment variable.
> 
> In your commit message, also mention what GIT_PROTOCOL contains
> (version=?). (From this commit message alone, I would have expected a
> lone integer, but that is not the case.)
> 
> Same comment for the commit message of PATCH v3 08/10.

I'll update the commit msgs.

-- 
Brandon Williams