Re: [PATCHv9 4/4] status: better advices when splitting a commit (during rebase -i)
- From
- konglu@minatec.inpg.fr <konglu@minatec.inpg.fr>
- Date
- Jun 7, 2012, 21:05 UTC
- Message-ID
- <20120607230527.Horde.vsZkPXwdC4BP0ReXmNcTX0A@webmail.minatec.grenoble-inp.fr>
- In-Reply-To
- <7v8vfyg8ga.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> a écrit :
Show 9 quoted lines
> Lucien Kong <Lucien.Kong@ensimag.imag.fr> writes:
>
>> +static char *read_line_from_git_path(const char *filename)
>> +{
>> + struct strbuf buf = STRBUF_INIT;
>> + FILE *fp = fopen(git_path(filename), "r");
>
> We currently do not pass any filename with per-cent in it, but that
> call should be git_path("%s", filename) for sanity.Thanks, that should fix our problem (sometimes, a warning message appears during compilation about this line and we didn't know what to change).