Re: [PATCHv6 2/4] t7512-status-help.sh: better advices for git status

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 4, 2012, 15:04 UTC
Message-ID: <7vbokzunid.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120604120406.Horde.ge3VMHwdC4BPzIgWN72l8oA@webmail.minatec.grenoble-inp.fr>

konglu@minatec.inpg.fr writes:

Show 14 quoted lines

> Junio C Hamano <gitster@pobox.com>:
> ...
>> Please be consistent.  If you want _me_ to pick one, I'd say
>>
>> 	test_when_finished 'rm -fr git' &&
>>         git init git &&
>>         (
>>         	cd git &&
>>                 ... do everything in git subdirectory ...
>> 	)
>>
>> would be my choice.
>
> Btw, should each test be independant with the others?

It would be ideal if you can make them independent with each other, so that after one fails, later ones do not have to.

> Wouldn't it be better if we remove the "git init git" part?

If you do not need to keep your tests from using the test repository in $TRASH_DIRECTORY (e.g. "t/trash directory.t7512-status-help"), you do not have to create a new one with "git init".