Re: [PATCHv3 1/2] wt-status.*: better advices for git status added
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 30, 2012, 17:24 UTC
- Message-ID
- <7vvcjdzini.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120530130914.Horde.CK7IZHwdC4BPxf-ak9fkbPA@webmail.minatec.grenoble-inp.fr>
konglu@minatec.inpg.fr writes:
Show 10 quoted lines
>> It strikes me odd that this is not listed next to statusHints, and >> it also makes me wonder if we even need to invent a new one, or it >> is better to just make the output more verbose when statusHints is >> not being declined. > > Yes, we first thought that we could use statusHints to protect the > new messages warnings. But users that disabled statusHints and still > wished to know what to do during am/rebase/bisect etc. won't be > able to. On the other hand, if they want to hide the new advices, they > can see in the doc the presence of the advice.statusHelp and disable it.
"When we have more more knobs, we can differentiate more cases" is not a valid argument, unless you can successfully argue that it is worth differentiating these subcases. Otherwise it is just another useless knob the user needs to tweak without real gain.
In this particular case, I think the new text is merely an extension of existing help text. Those who have already declined statusHints should not be bothered by it, and those who are being helped by them would benefit from the help text being more complete.