From: konglu@minatec.inpg.fr Date: Thu, 07 Jun 2012 21:05:27 GMT Subject: Re: [PATCHv9 4/4] status: better advices when splitting a commit (during rebase -i) Message-ID: <20120607230527.Horde.vsZkPXwdC4BP0ReXmNcTX0A@webmail.minatec.grenoble-inp.fr> In-Reply-To: <7v8vfyg8ga.fsf@alter.siamese.dyndns.org> Junio C Hamano a écrit : > Lucien Kong writes: > >> +static char *read_line_from_git_path(const char *filename) >> +{ >> + struct strbuf buf = STRBUF_INIT; >> + FILE *fp = fopen(git_path(filename), "r"); > > We currently do not pass any filename with per-cent in it, but that > call should be git_path("%s", filename) for sanity. Thanks, that should fix our problem (sometimes, a warning message appears during compilation about this line and we didn't know what to change).