Re: [PATCH] Proof-of-concept patch to remember what the detached HEAD was

From: Jeff King <peff@peff.net>
Date: Oct 14, 2009, 15:39 UTC
Message-ID: <20091014153934.GA3680@coredump.intra.peff.net>
In-Reply-To: <alpine.DEB.1.00.0910141233060.4985@pacific.mpi-cbg.de>

On Wed, Oct 14, 2009 at 12:33:22PM +0200, Johannes Schindelin wrote:

Show 16 quoted lines

> > > +char *get_detached_head_string(void)
> > > +{
> > > +	char *filename = git_path("DETACH_NAME");
> > > +	struct stat st;
> > > +	if (stat(filename, &st) || !S_ISREG(st.st_mode))
> > > +		return NULL;
> > > +	struct strbuf buf = STRBUF_INIT;
> > > +	strbuf_read_file(&buf, filename, st.st_size);
> > > +	strbuf_trim(&buf);
> > > +	return strbuf_detach(&buf, 0);
> > > +}
> > 
> > Would it hurt to tuck this information into HEAD itself, as we already
> > put arbitrary text into FETCH_HEAD?
> 
> AFAIR we still remember HEAD to be a symlink.

I think that has been abandoned for detached HEAD (that is, if you support only symlinked HEAD, then you cannot detach at all). But I might be wrong. It has been a while since I looked at that code.

-Peff