From: Jakub Narebski <jnareb@gmail.com>
Date: Tue, 30 Jun 2009 20:23:22 GMT
Subject: Re: [PATCHv8 6/7] gitweb: picon avatar provider
Message-ID: <200906302223.23190.jnareb@gmail.com>
In-Reply-To: <1246312854-3365-7-git-send-email-giuseppe.bilotta@gmail.com>

On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:

> Simple implementation of picon that only relies on the indiana.edu
> database.
> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>

Well written, and nice example how to add other avatar providers.

Acked-by: Jakub Narebski <jnareb@gmail.com>

[...]
> -	# Currently only the gravatar provider is available, and it
> -	# depends on Digest::MD5. If an unknown provider is specified,
> -	# the feature is disabled.
> +	# Currently available providers are gravatar and picon.
> +	# If an unknown provider is specified, the feature is disabled.
> +
> +	# Gravatar depends on Digest::MD5.
> +	# Picon currently relies on the indiana.edu database.

[...]
> -	# Currently only gravatars are supported, but other forms such as
> -	# picons can be added by putting an else up here and defining $url
> +	# Other providers can be added by extending the if chain, defining $url
>  	# as needed. If no variant puts something in $url, we assume avatars
>  	# are completely disabled/unavailable.

I see that you have updated comments too.

-- 
Jakub Narebski
Poland