git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Make git-clean a builtin

From
CRCarlos Rica <jasampler@gmail.com>
Date
Nov 5, 2007, 22:10 UTC
Message-ID
<1b46aba20711051410h370072e7he9cbebb54a789dac@mail.gmail.com>
In-Reply-To
<7vejf4pf7r.fsf@gitster.siamese.dyndns.org>
2007/11/5, Junio C Hamano <gitster@pobox.com>:
Show 9 quoted lines
> Shawn Bohrer <shawn.bohrer@gmail.com> writes:
>
> > +static int show_only = 0;
> > +static int remove_directories = 0;
> > +static int quiet = 0;
> > +static int ignored = 0;
> > +static int ignored_only = 0;
>
> Please do not explicitly initialize static variables to zero.

Is it really needed to declare those variables outside of a function in this case? This scheme makes difficult reusing the code from other builtins, rewriting it for libification, calling it many times, or even understand if they were declared that way with a purpose or not. I just don't know why they are that way in this case, is there a reason for it?

Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 15 in “[RFC] Second attempt at making git-clean a builtin”
  1. Shawn BohrerNov 4, 2007
  2. Add more tests for git-cleanShawn Bohrer, Nov 4, 2007
  3. Make git-clean a builtinShawn Bohrer, Nov 4, 2007
  4. Pierre HabouzitNov 4, 2007
  5. 3/2 Use parse-options in builtin-cleanJohannes Schindelin, Nov 4, 2007
  6. Pierre HabouzitNov 4, 2007
  7. Junio C HamanoNov 5, 2007
  8. Carlos RicaNov 5, 2007
  9. Junio C HamanoNov 5, 2007
  10. Shawn BohrerNov 6, 2007
  11. Junio C HamanoNov 6, 2007
  12. Junio C HamanoNov 4, 2007
  13. Pierre HabouzitNov 4, 2007
  14. Junio C HamanoNov 5, 2007
  15. Johannes SchindelinNov 4, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.