Re: [PATCH] Add more tests for git-clean

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 5, 2007, 00:17 UTC
Message-ID: <7vr6j5r1ec.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071104234617.GG4207@artemis.corp>

Pierre Habouzit <madcoder@debian.org> writes:

Show 16 quoted lines

> On Sun, Nov 04, 2007 at 11:35:42PM +0000, Junio C Hamano wrote:
>> Shawn Bohrer <shawn.bohrer@gmail.com> writes:
>> 
>> > +test_expect_success 'git-clean with prefix' '
>> > +
>> > +	mkdir -p build docs &&
>> > +	touch a.out src/part3.c docs/manual.txt obj.o build/lib.so &&
>> > +	cd src/ &&
>> > +	git-clean &&
>> > +	cd - &&
>> 
>> This is wrong for two reasons.
>> 
>>  - Is "cd -" portable?
>
>   this is POSIX:

That actually doesn't matter. What the real world shells do matters more.

In addition, "cd -" is a nice shorthand for interactive use but it is a bad discipline to use it in a script anyway.

	...
	( cd src && git-clean ) &&
	...

would be the best way to write this.