Re: [PATCH] Make git-clean a builtin

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 5, 2007, 23:54 UTC
Message-ID: <7v4pg0meol.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1b46aba20711051410h370072e7he9cbebb54a789dac@mail.gmail.com>

"Carlos Rica" <jasampler@gmail.com> writes:

Show 13 quoted lines

> 2007/11/5, Junio C Hamano <gitster@pobox.com>:
>> Shawn Bohrer <shawn.bohrer@gmail.com> writes:
>>
>> > +static int show_only = 0;
>> > +static int remove_directories = 0;
>> > +static int quiet = 0;
>> > +static int ignored = 0;
>> > +static int ignored_only = 0;
>>
>> Please do not explicitly initialize static variables to zero.
>
> Is it really needed to declare those variables outside of a function
> in this case?

I do not think so --- I suspect that this is a simple cut & paste from the standalone ls-files implementation.