Re: [PATCH] Add more tests for git-clean

From: Pierre Habouzit <madcoder@debian.org>
Date: Nov 4, 2007, 23:46 UTC
Message-ID: <20071104234617.GG4207@artemis.corp>
In-Reply-To: <7vve8hr3ch.fsf@gitster.siamese.dyndns.org>

On Sun, Nov 04, 2007 at 11:35:42PM +0000, Junio C Hamano wrote:

Show 13 quoted lines

> Shawn Bohrer <shawn.bohrer@gmail.com> writes:
> 
> > +test_expect_success 'git-clean with prefix' '
> > +
> > +	mkdir -p build docs &&
> > +	touch a.out src/part3.c docs/manual.txt obj.o build/lib.so &&
> > +	cd src/ &&
> > +	git-clean &&
> > +	cd - &&
> 
> This is wrong for two reasons.
> 
>  - Is "cd -" portable?

  this is POSIX:

8910 − When a hyphen is used as the operand, this shall be equivalent to the command: 8911 cd "$OLDPWD" && pwd 8912 which changes to the previous working directory and then writes its name.

  Meaning that cd $OLDPWD should work, and won't print $OLDPWD.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org