From: Carlos Rica <jasampler@gmail.com>
Date: Mon, 05 Nov 2007 22:10:13 GMT
Subject: Re: [PATCH] Make git-clean a builtin
Message-ID: <1b46aba20711051410h370072e7he9cbebb54a789dac@mail.gmail.com>
In-Reply-To: <7vejf4pf7r.fsf@gitster.siamese.dyndns.org>

2007/11/5, Junio C Hamano <gitster@pobox.com>:
> Shawn Bohrer <shawn.bohrer@gmail.com> writes:
>
> > +static int show_only = 0;
> > +static int remove_directories = 0;
> > +static int quiet = 0;
> > +static int ignored = 0;
> > +static int ignored_only = 0;
>
> Please do not explicitly initialize static variables to zero.

Is it really needed to declare those variables outside of a function
in this case? This scheme makes difficult reusing the code from other
builtins, rewriting it for libification, calling it many times, or
even understand if they were declared that way with a purpose or not.
I just don't know why they are that way in this case, is there a
reason for it?