Re: [PATCH] Make git-clean a builtin

From: Shawn Bohrer <shawn.bohrer@gmail.com>
Date: Nov 6, 2007, 05:05 UTC
Message-ID: <20071106050512.GA6768@mediacenter.austin.rr.com>
In-Reply-To: <7vejf4pf7r.fsf@gitster.siamese.dyndns.org>

On Mon, Nov 05, 2007 at 01:14:32PM -0800, Junio C Hamano wrote:

Show 7 quoted lines

> Shawn Bohrer <shawn.bohrer@gmail.com> writes:
> [...]
> > +static int disabled = 1;
> 
> This means we are committed to make clean.requireForce default
> to true, which is fine by me.  I need to warn the users about
> this early.

Actually I don't care either way, but in my last rebase on next this change was already made to git-clean.sh so I adjusted accordingly.

Show 7 quoted lines

> > +static int show_only = 0;
> > +static int remove_directories = 0;
> > +static int quiet = 0;
> > +static int ignored = 0;
> > +static int ignored_only = 0;
> 
> Please do not explicitly initialize static variables to zero.

I realize that static variables will be automatically initialized to zero so this is unnecessary, but is there some technical reason not to initialize explicitly? If the answer is simply a style preference that is fine, I'm just here to learn.

Of course as already pointed out these don't actually need to be static in the first place so I'll simply move them into cmd_clean(). This does lead me to another question though. Now that Dscho has converted my patch to use parse-options, what is the best way to update my patch while still giving credit to Dscho?