Re: [PATCH] Add more tests for git-clean

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 4, 2007, 23:49 UTC
Message-ID: <Pine.LNX.4.64.0711042348540.4362@racer.site>
In-Reply-To: <7vve8hr3ch.fsf@gitster.siamese.dyndns.org>

Hi,

On Sun, 4 Nov 2007, Junio C Hamano wrote:

Show 16 quoted lines

> Shawn Bohrer <shawn.bohrer@gmail.com> writes:
> 
> > +test_expect_success 'git-clean with prefix' '
> > +
> > +	mkdir -p build docs &&
> > +	touch a.out src/part3.c docs/manual.txt obj.o build/lib.so &&
> > +	cd src/ &&
> > +	git-clean &&
> > +	cd - &&
> 
> This is wrong for two reasons.
> 
>  - Is "cd -" portable?
> 
>  - What happens when git-clean fails?  This test fails, and then
>    it goes on to the next test without cd'ing back.

So it should be

	(cd src/ && git clean) &&

right? (Note that I also removed the dash, since it will be a builtin after the next commit.)

Ciao, Dscho