Re: [PATCH] remote-helpers: point at their upstream repositories

From: Junio C Hamano <gitster@pobox.com>
Date: May 19, 2014, 22:27 UTC
Message-ID: <xmqqzjidv1y4.fsf@gitster.dls.corp.google.com>
In-Reply-To: <537a75e0a53b7_afee5d300f3@nysa.notmuch>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 7 quoted lines

>> We could add these two to the warning, then, to discourage people
>> who see "please visit this URL" and say "Yuck, I have no time for
>> that" without actually visiting.
>
> We could. Personally I don't see the point of making the warning any
> more annoying. The instructiosn are just one click away, and if they
> have no time for that, they can just ignore the warning.

Yes, if they know a short-and-sweet instruction is at the top of the page, "just one click away" is a good justification, but the reason I suggested to add the instruction to the warning is because the URL alone does not tell them that there is a short and easy-to-follow instruction is behind it, not giving them enough clue to judge if they have time for that or not.

Show 5 quoted lines

> To me the endgame is that the code is removed, and only stubs remain.
> ...
> I meant I want 3. eventually, hopefully for v2.1.
> ...
> No, I don't want them crippled for v2.0. A warning should suffice.

OK, I think I understand what you want, and I am fine with that timeline.

I can start preparing -rc4 now, but it may slip into tomorrow.

Thanks.