Re: [PATCH] remote-helpers: point at their upstream repositories

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 20, 2014, 02:06 UTC
Message-ID: <537ab8a0d1304_2edfa832fc53@nysa.notmuch>
In-Reply-To: <xmqqvbt1uzo0.fsf@gitster.dls.corp.google.com>

Junio C Hamano wrote:

Show 15 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Felipe Contreras <felipe.contreras@gmail.com> writes:
> >
> >> We could. Personally I don't see the point of making the warning any
> >> more annoying....
> 
> If we were giving the users a choice of "no thanks, I'll keep using
> the obsolete one", then trying to be a low key and giving them a way
> to squelch with an advice.* config might make sense, but if we plan
> to remove/stub at as early as v2.1, I think annoyance is very much
> what we want, actually, because it clearly is the case that we do
> prefer users switching instead of waiting for v2.1.
> 
> How does this sound?

The patch below assumes the user has ~/bin in his PATH, which might not be the case. Personally I don't see the point of creating extra annoyance with instructions that might not work.

-- 
Felipe Contreras