Re: [PATCH] remote-helpers: point at their upstream repositories

From: Junio C Hamano <gitster@pobox.com>
Date: May 20, 2014, 04:32 UTC
Message-ID: <xmqq4n0l2hq0.fsf@gitster.dls.corp.google.com>
In-Reply-To: <537ab8a0d1304_2edfa832fc53@nysa.notmuch>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 20 quoted lines

> Junio C Hamano wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>> 
>> > Felipe Contreras <felipe.contreras@gmail.com> writes:
>> >
>> >> We could. Personally I don't see the point of making the warning any
>> >> more annoying....
>> 
>> If we were giving the users a choice of "no thanks, I'll keep using
>> the obsolete one", then trying to be a low key and giving them a way
>> to squelch with an advice.* config might make sense, but if we plan
>> to remove/stub at as early as v2.1, I think annoyance is very much
>> what we want, actually, because it clearly is the case that we do
>> prefer users switching instead of waiting for v2.1.
>> 
>> How does this sound?
>
> The patch below assumes the user has ~/bin in his PATH, which might not
> be the case. Personally I don't see the point of creating extra
> annoyance with instructions that might not work.

Yeah, I would be lying if I said that "that might not work" did not bother me, but I decided it would be on the good side of the borderline (it is better to be concise and slightly wrong than ultra-verbose and precise). As you may have guessed, they were stolen from your earlier message that shows what the site says after all ;-)

I will probably tag -rc4 with the patch applied sometime tomorrow.