Re: [PATCH v1] travis-ci: build and test Git on Windows
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 23, 2017, 19:30 UTC
- Message-ID
- <xmqqzigbbxjq.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <FE4A3F88-0B86-4069-B141-2DFB9C4E269E@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
> "[...] we do not provide these values to untrusted builds, > triggered by pull requests from another repository." > > See: https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings
OK, it is a releaf to see an indication that somebody over there is thinking. Thanks.
So we do _not_ have to turn it off; as soon as we define sekrit variables, they will turn it off for us ;-).
Show 5 quoted lines
>> Hrm, it does mean that people have no way to test on Windows until the >> branch hits pu. Which is not ideal. > > I agree it's not ideal. But I think it is an improvement to check > pu/next/master/maint continuously :-)
I am not sure what you mean. We are building each and every branch updates already, and I do not see any improvement over what we are doing now. Care to elaborate?