git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1] travis-ci: build and test Git on Windows

From
Lars Schneider <larsxschneider@gmail.com>
Date
Mar 23, 2017, 20:39 UTC
Message-ID
<CEE52E60-F31F-4BA9-BA79-7526EE6C5397@gmail.com>
In-Reply-To
<20170323202002.lfpuglqawz4ooruw@sigill.intra.peff.net>
Show 14 quoted lines
> On 23 Mar 2017, at 21:20, Jeff King <peff@peff.net> wrote:
> 
> On Thu, Mar 23, 2017 at 09:00:33PM +0100, Lars Schneider wrote:
> 
>>> Ah, OK, that makes sense. So we would only have to worry about our _own_
>>> code accidentally disclosing it. But that should be easy to look for by
>>> grepping the log (did somebody do that?).
>> 
>> This is how a successful Windows build would look like:
>> https://travis-ci.org/larsxschneider/git/jobs/214391822
>> 
>> Dscho's token is not in the log.
> 
> Great, thank you for double-checking.

I can see that one could think that this variables leaks, though. I think in v2 I won't pass the token as parameter. The token variable is an environment variable anyways and I can just use it in the script.

Show 13 quoted lines
>>> - I have a lot of work-in-progress branches. I put "-wip" at the end
>>>   of the branch name for my own scripts. It looks like I can put "[ci
>>>   skip]" in the commit subject to convince Travis to skip them, but
>>>   that's a little annoying. Is there any way to skip based on just the
>>>   branch name? I couldn't find one.
>> 
>> We can blacklist these branches with a regex in the travis.yml:
>> https://docs.travis-ci.com/user/customizing-the-build#Building-Specific-Branches
> 
> I had a feeling it might be something like that. So we would all need to
> agree on the convention for WIP branch names. If other people like the
> idea, I'm happy to make a patch, but I don't want to impose my own weird
> conventions on everyone else.

This makes sense to me. If someone complains with a good argument then we can still revert it.

Show 12 quoted lines
>> Maybe TravisCI throttles your usage somehow as you push a lot of commits?
> 
> Could be. Looking at:
> 
>  https://travis-ci.org/peff/git/branches
> 
> It seems to timeout on over half the branches (in fact, there are only a
> few that passed all of the tests). My pattern is particularly spiky from
> Travis's perspective, because once a day I rebase everything on top of
> master and push them the whole thing in a bunch. So they 75 branches,
> all at once. That seems like it would be ripe for throttling (though I
> would much rather they just queue the builds and do them one at a time).

Could you try to set this to 7 or less in your TravisCI? https://docs.travis-ci.com/user/customizing-the-build#Limiting-Concurrent-Builds

I am curious if this improves the situation.
- Lars
Previous: Jeff KingNext: Jeff King
Message 18 of 24 in “travis-ci: build and test Git on Windows”
  1. travis-ci: build and test Git on WindowsLars Schneider, Mar 22, 2017
  2. Johannes SchindelinMar 22, 2017
  3. Lars SchneiderMar 23, 2017
  4. Junio C HamanoMar 22, 2017
  5. Johannes SchindelinMar 23, 2017
  6. Jeff KingMar 23, 2017
  7. Junio C HamanoMar 23, 2017
  8. Jeff KingMar 23, 2017
  9. Lars SchneiderMar 23, 2017
  10. Junio C HamanoMar 23, 2017
  11. Lars SchneiderMar 23, 2017
  12. Junio C HamanoMar 23, 2017
  13. Jeff KingMar 23, 2017
  14. Lars SchneiderMar 23, 2017
  15. Jeff KingMar 23, 2017
  16. Junio C HamanoMar 23, 2017
  17. Jeff KingMar 23, 2017
  18. Lars SchneiderMar 23, 2017
  19. Jeff KingMar 23, 2017
  20. Johannes SchindelinMar 24, 2017
  21. Samuel LijinMar 23, 2017
  22. Junio C HamanoMar 23, 2017
  23. Lars SchneiderMar 23, 2017
  24. Junio C HamanoMar 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.