git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1] travis-ci: build and test Git on Windows

From
Jeff King <peff@peff.net>
Date
Mar 23, 2017, 18:01 UTC
Message-ID
<20170323180134.geoyvq7qbm5vujo6@sigill.intra.peff.net>
In-Reply-To
<alpine.DEB.2.20.1703231716320.3767@virtualbox>
On Thu, Mar 23, 2017 at 05:22:51PM +0100, Johannes Schindelin wrote:
Show 13 quoted lines
> > The benefit is that Windows CI does not have to subscribe to the
> > GitHub repository to get notified (instead uses Travis as a relay
> > for update notification) and the result can be seen at the same
> > place as results on other platforms Travis natively support are
> > shown?  
> 
> Almost... Windows CI *cannot* subscribe to the GitHub repository, as only
> owners can install web hooks and give permission to update build status.
> 
> But yeah, you understand correctly: this innocuous change (along with a
> ton of work I already finished on my side) allows us to let Travis trigger
> Windows build & test and to attach the log in the same place as the
> Linux/OSX results are already accessible.

I don't mind adding a webhook if it helps. If I understand correctly that would just handle the notification site. But then if the Windows build status were public, we could have Travis simply fetch it to keep the build reports all together, without having to worry about a secret token.

I don't mind proceeding with the secret token, though. You're the owner of the service the token accesses, so if you're comfortable with it, I am.

Show 11 quoted lines
> > > Things, that would need to be done:
> > > * Someone with write access to https://travis-ci.org/git/git would need
> > >   to add the secret token as "GFW_CI_TOKEN" variable in the TravisCI
> > >   repository setting [1]. Afterwards the build should just work.
> > 
> > We need to make sure this does not leak to the execution log of
> > Travis.
> [...]
> 
> Right, typically there is a way in CI setups that marks certain strings as
> secret and whenever they appear in the log, they will be blotted out.

I think both Junio and I have access to the Travis config. Travis does have a "this is secret" flag for setup config. But I think we'd need to verify that running the Travis build does not leak the variable in any other way.

For instance, if it's in the environment, can I push up a branch that does "set | grep GFW_CI_TOKEN", open a PR, and see it? I don't know the answer.

-Peff
Previous: Johannes SchindelinNext: Junio C Hamano
Message 6 of 24 in “travis-ci: build and test Git on Windows”
  1. travis-ci: build and test Git on WindowsLars Schneider, Mar 22, 2017
  2. Johannes SchindelinMar 22, 2017
  3. Lars SchneiderMar 23, 2017
  4. Junio C HamanoMar 22, 2017
  5. Johannes SchindelinMar 23, 2017
  6. Jeff KingMar 23, 2017
  7. Junio C HamanoMar 23, 2017
  8. Jeff KingMar 23, 2017
  9. Lars SchneiderMar 23, 2017
  10. Junio C HamanoMar 23, 2017
  11. Lars SchneiderMar 23, 2017
  12. Junio C HamanoMar 23, 2017
  13. Jeff KingMar 23, 2017
  14. Lars SchneiderMar 23, 2017
  15. Jeff KingMar 23, 2017
  16. Junio C HamanoMar 23, 2017
  17. Jeff KingMar 23, 2017
  18. Lars SchneiderMar 23, 2017
  19. Jeff KingMar 23, 2017
  20. Johannes SchindelinMar 24, 2017
  21. Samuel LijinMar 23, 2017
  22. Junio C HamanoMar 23, 2017
  23. Lars SchneiderMar 23, 2017
  24. Junio C HamanoMar 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.